Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module-info and compile it with Java 9+ #620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tsmock
Copy link
Contributor

@tsmock tsmock commented Aug 15, 2023

This fixes #566.

With that said, this is typically not the preferred method until all dependencies at least have the Automatic-Module-Name manifest entry -- ideally, the xmpcore project would add an Automatic-Module-Name entry to its manifest, but I somehow doubt that will happen.

From the compile-time output:

Required filename-based automodules detected: [xmpcore-6.1.11.jar]. Please don't publish this project to a public artifact repository!

See also #621 .

@drewnoakes
Copy link
Owner

This looks like the long term solution, but until xmp-core sports modules, we are stuck with the approach from #621.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add module-info for java9+
2 participants