Installing nuget package adds tons of unnecessary references

[errantmind]

Hey, when installing Figgle using nuget a bunch of unnecessary references are added to the project. None of these references are actually needed except Figgle. These references make it look suspicious because a lot of them are cryptography related and other stuff unrelated to Figgle's core function.

edit: or maybe it does need all those references, in that case, why?

[drewnoakes]

Are you referencing Figgle from a .NET Core project?

[errantmind]

No, regular .Net 4.6.2 . Maybe the references are needed? Just seems like a lot for ascii text generation

…

On Oct 19, 2017 15:16, "Drew Noakes" ***@***.***> wrote: Are you referencing Figgle from a .NET Core project? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADgqLLHvxQr-awA5FkGJJFXSl_SIMzh4ks5st64BgaJpZM4P_wFf> .

[drewnoakes]

Totally agree they should not be there. I've seen this with other libraries. Fix/workaround for now is to target both netstandard1.3 and net45 (or similar) in the csproj and package. I'll get a new version out.

[errantmind]

The timeline, for clarity, is: 1. Add figgle nuget package to project 2. 20+ dll references added to References and packages.config

…

On Oct 19, 2017 15:44, "James Bates" ***@***.***> wrote: No, regular .Net 4.6.2 . Maybe the references are needed? Just seems like a lot for ascii text generation On Oct 19, 2017 15:16, "Drew Noakes" ***@***.***> wrote: > Are you referencing Figgle from a .NET Core project? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#3 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ADgqLLHvxQr-awA5FkGJJFXSl_SIMzh4ks5st64BgaJpZM4P_wFf> > . >

[errantmind]

Appreciate the explanation. I like the project, thanks for putting it together

…

On Oct 19, 2017 15:45, "Drew Noakes" ***@***.***> wrote: Totally agree they should not be there. I've seen this with other libraries. Fix/workaround for now is to target both netstandard1.3 and net45 (or similar) in the csproj and package. I'll get a new version out. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADgqLLgLlL71sehgxmGI_0LUtkrs83x4ks5st7T4gaJpZM4P_wFf> .

[drewnoakes]

Please try out version 0.3.0 from NuGet. I believe the problem should be resolved now.

[drewnoakes]

(You may have to wait a few minutes before it appears in the index)

[drewnoakes]

Did you get a chance to test this?

[errantmind]

Not just yet but I'll be able to this afternoon

…

On Oct 21, 2017 02:24, "Drew Noakes" ***@***.***> wrote: Did you get a chance to test this? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADgqLEb05vMeS0Y0tooG_sedHi0POyvNks5suZwngaJpZM4P_wFf> .

[errantmind]

I'm now getting an exception. Note, System.IO.Compression still gets added to references when I add the Figgle nuget package. Not sure if related: System.IO.FileNotFoundException occurred HResult=0x80070002 Message=Could not load file or assembly 'System.IO.Compression, Version=4.1.2.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' or one of its dependencies. The system cannot find the file specified. Source=Figgle StackTrace: at Figgle.FiggleFonts.FontFactory(String name) at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory) at Figgle.FiggleFonts.Lookup(String name) at Figgle.FiggleFonts.get_Standard() at Phoenix.Program.Main(String[] args) in C:\Users\LocalUser\documents\visual studio 2017\Projects\Phoenix\Program.cs:line 14 Inner Exception 1: FileNotFoundException: Could not load file or assembly 'System.IO.Compression, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' or one of its dependencies. The system cannot find the file specified.

…

On Sun, Oct 22, 2017 at 12:51 PM, James Bates ***@***.***> wrote: Hey, the fix looks good. There is still one reference that gets added (aside from Figgle itself) which is "System.IO.Compression". Not sure if this is necessary but there is a lot less clutter now. Thanks, -- James On Sat, Oct 21, 2017 at 10:25 AM, James Bates ***@***.***> wrote: > Not just yet but I'll be able to this afternoon > > On Oct 21, 2017 02:24, "Drew Noakes" ***@***.***> wrote: > >> Did you get a chance to test this? >> >> — >> You are receiving this because you authored the thread. >> Reply to this email directly, view it on GitHub >> <#3 (comment)>, >> or mute the thread >> <https://github.com/notifications/unsubscribe-auth/ADgqLEb05vMeS0Y0tooG_sedHi0POyvNks5suZwngaJpZM4P_wFf> >> . >> >

[errantmind]

This looks like a problem on my part as my App.config was still contaminated from the previous version of Figgle. Everything works fine now, this issue can be closed.