Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netstandard2.0 support #15

Closed
WeihanLi opened this issue Dec 3, 2022 · 1 comment · Fixed by #16
Closed

netstandard2.0 support #15

WeihanLi opened this issue Dec 3, 2022 · 1 comment · Fixed by #16

Comments

@WeihanLi
Copy link

WeihanLi commented Dec 3, 2022

accounting to microsoft dotnet open source library guide here

✔️ DO start with including a netstandard2.0 target.

Most general-purpose libraries should not need APIs outside of .NET Standard 2.0. .NET Standard 2.0 is supported by all modern platforms and is the recommended way to support multiple platforms with one target.

❌ AVOID including a netstandard1.x target.

.NET Standard 1.x is distributed as a granular set of NuGet packages, which creates a large package dependency graph and results in developers downloading a lot of packages when building. Modern .NET platforms, including .NET Framework 4.6.1, UWP and Xamarin, all support .NET Standard 2.0. You should only target .NET Standard 1.x if you specifically need to target an older platform.

✔️ DO include a netstandard2.0 target if you require a netstandard1.x target.

All platforms supporting .NET Standard 2.0 will use the netstandard2.0 target and benefit from having a smaller package graph while older platforms will still work and fall back to using the netstandard1.x target.

drewnoakes added a commit that referenced this issue Dec 6, 2022
Fixes #15

Drops support for .NET Core 1.0/1.1 and .NET Framework 4.5.1/4.5.2/4.6, all of which are out of support. Users who require those versions should remain on Figgle version 0.4.1.
@drewnoakes
Copy link
Owner

Thanks, that's a good point. Fixed in #16.

I'm hoping to get the source generator work finished too before releasing a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants