Skip to content

Commit

Permalink
chore: Remove unused pod in addArchiveLocation() (argoproj#3200)
Browse files Browse the repository at this point in the history
  • Loading branch information
terrytangyuan committed Jun 9, 2020
1 parent 8e1d56c commit 285eda6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions workflow/controller/workflowpod.go
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ func (woc *wfOperationCtx) createWorkflowPod(nodeName string, mainCtr apiv1.Cont
pod.Spec.ShareProcessNamespace = pointer.BoolPtr(true)
}

err := woc.addArchiveLocation(pod, tmpl)
err := woc.addArchiveLocation(tmpl)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -844,7 +844,7 @@ func addOutputArtifactsVolumes(pod *apiv1.Pod, tmpl *wfv1.Template) {
// information configured in the controller, for the purposes of archiving outputs. This is skipped
// for templates which do not need to archive anything, or have explicitly set an archive location
// in the template.
func (woc *wfOperationCtx) addArchiveLocation(pod *apiv1.Pod, tmpl *wfv1.Template) error {
func (woc *wfOperationCtx) addArchiveLocation(tmpl *wfv1.Template) error {
// needLocation keeps track if the workflow needs to have an archive location set.
// If so, and one was not supplied (or defaulted), we will return error
var needLocation bool
Expand Down

0 comments on commit 285eda6

Please sign in to comment.