Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(render): horizon scroll bar #999

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix(render): horizon scroll bar #999

merged 1 commit into from
Jan 5, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Jan 4, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #998

Copy link

github-actions bot commented Jan 4, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (0be188d) 24.06% compared to head (5dabdb3) 13.60%.
Report is 4 commits behind head on dev.

Files Patch % Lines
packages/sheets-ui/src/views/sheet-canvas-view.ts 0.00% 9 Missing ⚠️
packages/engine-render/src/viewport.ts 0.00% 6 Missing and 1 partial ⚠️
...rc/views/sheet-bar/sheet-bar-tabs/SheetBarTabs.tsx 0.00% 4 Missing ⚠️
packages/docs/src/views/doc-canvas-view.ts 0.00% 1 Missing ⚠️
packages/engine-render/src/scene.ts 0.00% 1 Missing ⚠️
packages/engine-render/src/shape/scroll-bar.ts 0.00% 0 Missing and 1 partial ⚠️
packages/engine-render/src/thin-scene.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #999       +/-   ##
===========================================
- Coverage   24.06%   13.60%   -10.47%     
===========================================
  Files         139      284      +145     
  Lines        9869    23865    +13996     
  Branches     1987     5007     +3020     
===========================================
+ Hits         2375     3246      +871     
- Misses       6453    17500    +11047     
- Partials     1041     3119     +2078     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Jan 4, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jan 5, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We may should use English in comments and on GitHub.

@wzhudev wzhudev merged commit 6b07d0d into dev Jan 5, 2024
10 checks passed
@wzhudev wzhudev deleted the fix-horizen-scroll-bar branch January 5, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 页面特定的宽度打开控制台表格渲染异常
3 participants