Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #911 using the undo shortcut after you clear the content goes into edit mode #979

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Jan 3, 2024

close #911

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (d149d45) 24.07% compared to head (86ac0ff) 20.44%.
Report is 8 commits behind head on dev.

❗ Current head 86ac0ff differs from pull request most recent head 3951e07. Consider uploading reports for the commit 3951e07 to get more accurate results

Files Patch % Lines
...s/ui/src/views/components/doc-bars/ToolbarItem.tsx 0.00% 9 Missing and 1 partial ⚠️
...rc/views/sheet-bar/sheet-bar-tabs/SheetBarTabs.tsx 0.00% 4 Missing ⚠️
.../src/views/components/context-menu/ContextMenu.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #979      +/-   ##
==========================================
- Coverage   24.07%   20.44%   -3.63%     
==========================================
  Files         140      197      +57     
  Lines        9763    11618    +1855     
  Branches     1918     2374     +456     
==========================================
+ Hits         2350     2375      +25     
- Misses       6394     7927    +1533     
- Partials     1019     1316     +297     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Gggpound
Copy link
Contributor Author

Gggpound commented Jan 3, 2024

When you click on the toolbar or right-click on the menu, the editor loses focus. When the shortcut is triggered, the focus is on the body and execution is interrupted at the following location.

@Gggpound
Copy link
Contributor Author

Gggpound commented Jan 3, 2024

image

@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Jan 3, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jan 3, 2024
@Gggpound Gggpound merged commit a72c994 into dev Jan 3, 2024
9 checks passed
@Gggpound Gggpound deleted the fix-sheet-debug-0102 branch January 3, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 单元格设置格式(点击工具栏按钮)或使用右键菜单功能后,单元格失焦
4 participants