Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): sheet bar menu style #917

Merged
merged 4 commits into from
Jan 11, 2024
Merged

fix(sheet): sheet bar menu style #917

merged 4 commits into from
Jan 11, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Dec 27, 2023

  • I am sure that the code is update-to-date with the dev branch.

close #1023

  • sheet bar menu style: icon center vertically
  • fix: init no status true
  • active tab box shadow do not same with others
  • sheet name duplicate

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (22c71b9) 28.96% compared to head (d3431d8) 29.97%.
Report is 1 commits behind head on dev.

Files Patch % Lines
...rc/views/sheet-bar/sheet-bar-tabs/SheetBarItem.tsx 0.00% 1 Missing ⚠️
...eets/src/commands/commands/insert-sheet.command.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #917      +/-   ##
==========================================
+ Coverage   28.96%   29.97%   +1.01%     
==========================================
  Files         751      751              
  Lines       44337    44383      +46     
  Branches     9184     9194      +10     
==========================================
+ Hits        12841    13304     +463     
+ Misses      27521    27113     -408     
+ Partials     3975     3966       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 27, 2023

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir marked this pull request as ready for review December 29, 2023 06:37
@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Jan 2, 2024
@Dushusir Dushusir removed the qa:untested This PR is ready to be tested label Jan 2, 2024
@Dushusir Dushusir marked this pull request as draft January 2, 2024 09:47
@Dushusir
Copy link
Member Author

Dushusir commented Jan 2, 2024

@Eelson needs test

@Dushusir Dushusir force-pushed the fix/sheet-bar-bug branch 2 times, most recently from a46fde4 to 83bff49 Compare January 10, 2024 11:24
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Jan 10, 2024
@Dushusir Dushusir marked this pull request as ready for review January 10, 2024 11:32
@Dushusir
Copy link
Member Author

@Ella1117 needs test

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jan 11, 2024
@Dushusir Dushusir merged commit 2fa1683 into dev Jan 11, 2024
9 checks passed
@Dushusir Dushusir deleted the fix/sheet-bar-bug branch January 11, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 加tab 命名和原先sheet重复
4 participants