Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate zen editor to packages #914

Merged
merged 3 commits into from
Dec 28, 2023
Merged

refactor: migrate zen editor to packages #914

merged 3 commits into from
Dec 28, 2023

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Dec 27, 2023

  • I am sure that the code is update-to-date with the dev branch.

close #

@Jocs Jocs added the qa:untested This PR is ready to be tested label Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f9ce1e) 3.22% compared to head (d48b1c3) 0.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #914      +/-   ##
========================================
- Coverage   3.22%   0.00%   -3.23%     
========================================
  Files         93       8      -85     
  Lines      11304     249   -11055     
  Branches    2475      27    -2448     
========================================
- Hits         365       0     -365     
+ Misses      9190     225    -8965     
+ Partials    1749      24    -1725     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review December 27, 2023 11:10
Copy link

github-actions bot commented Dec 27, 2023

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Dec 28, 2023
@jikkai jikkai merged commit 5c34230 into dev Dec 28, 2023
9 checks passed
@jikkai jikkai deleted the refactor/zen-editor branch December 28, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants