Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more test for CommandService & LifecycleService #899

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Dec 26, 2023

  • I am sure that the code is update-to-date with the dev branch.

close #

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (c133211) 23.08% compared to head (9035aec) 30.67%.
Report is 7 commits behind head on dev.

Files Patch % Lines
...src/services/selection/selection-render.service.ts 0.00% 13 Missing ⚠️
...floating-object/floating-object-manager.service.ts 0.00% 10 Missing ⚠️
...heets-ui/src/services/selection/selection-shape.ts 0.00% 6 Missing and 1 partial ⚠️
packages/core/src/sheets/r1c1-reference.ts 81.81% 6 Missing ⚠️
...ui/src/controllers/editor/start-edit.controller.ts 0.00% 6 Missing ⚠️
...rc/services/selection/selection-shape-extension.ts 0.00% 6 Missing ⚠️
...ets-ui/src/controllers/editor-bridge.controller.ts 0.00% 5 Missing ⚠️
.../sheets-ui/src/controllers/selection.controller.ts 0.00% 5 Missing ⚠️
...heets-ui/src/controllers/header-move.controller.ts 0.00% 3 Missing and 1 partial ⚠️
...rc/services/permission/sheet-permission.service.ts 33.33% 4 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #899      +/-   ##
==========================================
+ Coverage   23.08%   30.67%   +7.58%     
==========================================
  Files         140      449     +309     
  Lines        9771    24327   +14556     
  Branches     1917     4889    +2972     
==========================================
+ Hits         2256     7463    +5207     
- Misses       6483    15110    +8627     
- Partials     1032     1754     +722     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 26, 2023

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev changed the title test: add more test for CommandService test: add more test for CommandService & LifecycleService Jan 2, 2024
@wzhudev wzhudev marked this pull request as ready for review January 2, 2024 00:54
@wzhudev wzhudev merged commit d8e4ef5 into dev Jan 2, 2024
9 checks passed
@wzhudev wzhudev deleted the wzhudev/polish-core branch January 2, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant