Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add turborepo for monorepo management #87

Merged
merged 3 commits into from
Sep 2, 2023
Merged

build: add turborepo for monorepo management #87

merged 3 commits into from
Sep 2, 2023

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Aug 31, 2023 •
edited
Loading

#67

@jikkai jikkai requested a review from wzhudev August 31, 2023 10:34
@jikkai jikkai marked this pull request as ready for review August 31, 2023 10:35
@wzhudev
Copy link
Member

wzhudev commented Aug 31, 2023

Esbuild 配置文件的部分配置能复用吗？

@jikkai
Copy link
Member Author

jikkai commented Aug 31, 2023 •
edited
Loading

@wzhudev done

@wzhudev
Copy link
Member

wzhudev commented Aug 31, 2023

现在添加的 monorepo 工具提供了哪些功能？

@jikkai
Copy link
Member Author

jikkai commented Sep 1, 2023

目前就提供了 build 和 cache，ci 迁移后会加上 test 和 lint

@wzhudev
Copy link
Member

wzhudev commented Sep 1, 2023

目前就提供了 build 和 cache，ci 迁移后会加上 test 和 lint

后面 dev 会用吗？

@jikkai
Copy link
Member Author

jikkai commented Sep 1, 2023

dev 感觉目前没必要走这个，增量构建的能力主要还是 build 和 ci 用
不过 dev 那堆脚本也要重新整一下，暂时就不在这次 PR 里处理里了

wzhudev
wzhudev approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev changed the title chore: add turborepo for monorepo management build: add turborepo for monorepo management Sep 2, 2023
@jikkai jikkai merged commit d0b3da9 into dream-num:dev Sep 2, 2023
@jikkai jikkai deleted the chore/monorepo branch September 2, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jikkai @wzhudev