Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc): support emoji #688

Merged
merged 7 commits into from
Dec 9, 2023
Merged

feat(doc): support emoji #688

merged 7 commits into from
Dec 9, 2023

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Dec 8, 2023

Copy link

github-actions bot commented Dec 8, 2023

View Deployment

📝 Doc 📊 Sheet 📽️ Slide
🔗 Preview link 🔗 Preview link 🔗 Preview link

View Storybook

📚 Storybook
🔗 Preview link

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (743dcec) 48.42% compared to head (b04fcaa) 41.07%.
Report is 8 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #688      +/-   ##
==========================================
- Coverage   48.42%   41.07%   -7.36%     
==========================================
  Files         214      297      +83     
  Lines       14434    18045    +3611     
  Branches     2946     3647     +701     
==========================================
+ Hits         6990     7412     +422     
- Misses       6375     9114    +2739     
- Partials     1069     1519     +450     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review December 8, 2023 15:14
Copy link

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wzhudev
Copy link
Member

wzhudev commented Dec 9, 2023

Debugger 里面增加一个渲染性能插件吧?

@Jocs
Copy link
Contributor Author

Jocs commented Dec 9, 2023

Debugger 里面增加一个渲染性能插件吧?

赞,性能瓶颈主要在 skeleton.calculate 上?我来搞一个

@Jocs
Copy link
Contributor Author

Jocs commented Dec 9, 2023

Debugger 里面增加一个渲染性能插件吧?

到时候也可以做一些优化前后的性能对比

@wzhudev
Copy link
Member

wzhudev commented Dec 9, 2023

这里先合入吧,后续再做调试插件

@Jocs Jocs merged commit 070807d into dev Dec 9, 2023
11 checks passed
@Jocs Jocs deleted the feat/support-emoji branch December 9, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support emoji in doc
3 participants