Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: umd support #686

Merged
merged 6 commits into from
Dec 9, 2023
Merged

chore: umd support #686

merged 6 commits into from
Dec 9, 2023

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Dec 8, 2023

No description provided.

Copy link

github-actions bot commented Dec 8, 2023

View Deployment

📝 Doc 📊 Sheet 📽️ Slide
🔗 Preview link 🔗 Preview link 🔗 Preview link

View Storybook

📚 Storybook
🔗 Preview link

@jikkai jikkai force-pushed the chore/vite branch 2 times, most recently from d18abb9 to b538139 Compare December 8, 2023 13:00
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8d7f40d) 34.46% compared to head (caab5d4) 19.23%.

Files Patch % Lines
packages/design/src/components/slider/Slider.tsx 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #686       +/-   ##
===========================================
- Coverage   34.46%   19.23%   -15.23%     
===========================================
  Files         347      679      +332     
  Lines       22126    39639    +17513     
  Branches     4411     8050     +3639     
===========================================
  Hits         7626     7626               
- Misses      12453    27227    +14774     
- Partials     2047     4786     +2739     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai marked this pull request as draft December 8, 2023 13:04
Copy link

sonarcloud bot commented Dec 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
27.3% 27.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@jikkai jikkai force-pushed the chore/vite branch 5 times, most recently from 1008513 to ed158b1 Compare December 9, 2023 12:24
@jikkai jikkai marked this pull request as ready for review December 9, 2023 12:41
@jikkai jikkai changed the title feat: umd support & set zh-CN as default language feat: umd support Dec 9, 2023
@jikkai jikkai changed the title feat: umd support chore: umd support Dec 9, 2023
@jikkai jikkai merged commit 3e4fdef into dev Dec 9, 2023
9 checks passed
@jikkai jikkai deleted the chore/vite branch December 9, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant