feat(sheet): formula show and add selection move #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DR-Univer
commented
Dec 7, 2023
•
DR-Univer
commented
- 为seletionManagerService增加了moveStart, moving, moveEnd的subject
- sid的函数可以在formula bar看到，能够在editor编辑
- 数组公式高亮，以及可以在formula bar查看。
- 数据公式非primary的单元格，公式置灰
- 新增ICellDataForSheetInceptor
- 解决双击编辑单元格不灵活问题
DR-Univer
requested review from
Dushusir,
Gggpound,
jikkai and
wzhudev
as code owners
DR-Univer
force-pushed
the
feat-array-formula-hightlight
branch
from
c20c98c
to
f384a1e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #676 +/- ##
==========================================
- Coverage 48.42% 41.22% -7.21%
==========================================
Files 214 296 +82
Lines 14434 17999 +3565
Branches 2946 3642 +696
==========================================
+ Hits 6990 7420 +430
- Misses 6375 9069 +2694
- Partials 1069 1510 +441 ☔ View full report in Codecov by Sentry. |
View Deployment
View Storybook
|
Dushusir
approved these changes
Dec 7, 2023
|
getFormulaItemBySId这里，后面我看下是不是可以保证初始化时就存储好，免去查找 |
Gggpound
approved these changes
Dec 8, 2023
DR-Univer
force-pushed
the
feat-array-formula-hightlight
branch
from
04da06e
to
2a34114
Compare
Jocs
approved these changes
Dec 8, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
lumixraku
added a commit
that referenced
this pull request
May 25, 2024
* fix(sheet): render viewport wrong size * fix: new viewport need more param * feat: cache by viewport * fix: markdirty & scrolling was conflict before, so scrolling & dirty did not refresh whole viewport * fix: 0510-1725 fix: #676 #677 fix: browser native zoom * fix: blurry when applyCache especially in windows 175% * fix: merge cells background fix: #676 test: #677 fix: #700 fix: aux line background fix: spreadsheet fix: precise rect for background * feat: fix cf render error on printing mode fix: #700 * fix: viewport make dirty false chore: eslint fix * test(facade): fix canvas mock fix: new viewport need more param222 test: mock canvas fix: rm useless * fix: should beginPath before clip() * chore: comments to english fix: expand shouldupdatecache chore: better code * fix: change viewport update timing fix: update visible cache viewport area --------- Co-authored-by: DR-Univer <[email protected]> Co-authored-by: zw <[email protected]> Co-authored-by: 白熱 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.