refactor(core): decompose API from core and refactor to new architecture #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzhudev
requested changes
Aug 25, 2023
packages/base-sheets/src/Basics/Interfaces/MutationInterface.ts
Outdated
Show resolved
Hide resolved
packages/base-sheets/src/Commands/Mutations/insert-sheet.mutation.ts
Outdated
Show resolved
Hide resolved
packages/base-sheets/src/Commands/Mutations/insert-sheet.mutation.ts
Outdated
Show resolved
Hide resolved
wzhudev
changed the title
wzhudev
reviewed
Aug 25, 2023
packages/ui-plugin-sheets/src/Controller/SheetBarUIContruller.ts
Outdated
Show resolved
Hide resolved
unuseful file
unuseful file
…-col worksheet-hidden
* refactor(sheet): move selection to new architecture * WIP: add shortcut commands and operation * feat: support moving cursor by shortcut * chore: update husky hook mode
wzhudev
reviewed
Aug 29, 2023
| import { IAccessor } from '@wendellhu/redi'; | ||
| import { IInsertColMutationParams, IInsertRowMutationParams, IRemoveColMutationParams, IRemoveRowMutationParams } from '../../Basics/Interfaces/MutationInterface'; | ||
|
|
||
| export const IRemoveRowMutationFactory = (accessor: IAccessor, params: IRemoveRowMutationParams): IInsertRowMutationParams => { |
|
目前写的 command 需要能够处理上层没有传递 params 的情况，即能够按照当前 sheet 的选区的状态自动执行对应的任务 cc @eiji-th @JerryJiangZh |
wzhudev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.