fix(base-sheet): fix incorrect rendering when the border type is set to outside #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #532 +/- ##
=======================================
Coverage 43.55% 43.55%
=======================================
Files 238 238
Lines 15263 15263
Branches 3122 3122
=======================================
Hits 6648 6648
Misses 7283 7283
Partials 1332 1332 ☔ View full report in Codecov by Sentry. |
View Deployment
View Storybook
|
wzhudev
reviewed
Nov 23, 2023
packages/base-sheets/src/commands/commands/set-border-command.ts
Outdated
Show resolved
Hide resolved
jikkai
force-pushed
the
fix/border-style
branch
from
bd8dffd
to
6760019
Compare
wzhudev
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⬇️