fix(ui-sheets): fix incorrect ctrl key detection in macOS #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #452 +/- ##
==========================================
- Coverage 38.60% 38.59% -0.01%
==========================================
Files 218 218
Lines 13627 13630 +3
Branches 2690 2691 +1
==========================================
Hits 5261 5261
- Misses 7054 7056 +2
- Partials 1312 1313 +1 ☔ View full report in Codecov by Sentry. |
View Deployment
View Storybook
|
wzhudev
requested changes
Nov 14, 2023
| @@ -473,7 +477,8 @@ export class SelectionRenderService implements ISelectionRenderService { | |||
| } | |||
|
|
|||
| // In addition to pressing the ctrl or shift key, we must clear the previous selection | |||
| if (curControls.length > 0 && !evt.ctrlKey && !evt.shiftKey && !this._isShowPreviousEnable) { | |||
| const ctrlKey = this._platformService.isMac ? evt.metaKey : evt.ctrlKey; | |||
There was a problem hiding this comment.
Extract this function to shortcut related module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.