Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BorderPanel & adjust the styling of ColorPicker #445

Merged
merged 9 commits into from
Nov 14, 2023

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Nov 13, 2023

image

Copy link

github-actions bot commented Nov 13, 2023

View Deployment

📝 Doc 📊 Sheet 📽️ Slide
🔗 Preview link 🔗 Preview link 🔗 Preview link

View Storybook

📚 Storybook
🔗 Preview link

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8cc4f58) 38.04% compared to head (d3b98eb) 38.60%.

Files Patch % Lines
...sheets/src/commands/commands/set-border-command.ts 16.66% 4 Missing and 1 partial ⚠️
...s/src/components/menu-item-input/MenuItemInput.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #445      +/-   ##
==========================================
+ Coverage   38.04%   38.60%   +0.55%     
==========================================
  Files         235      218      -17     
  Lines       13856    13627     -229     
  Branches     2716     2690      -26     
==========================================
- Hits         5272     5261      -11     
+ Misses       7254     7054     -200     
+ Partials     1330     1312      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai force-pushed the feat/menu-and-colorpicker branch 2 times, most recently from f4d3d5a to 6bcbc19 Compare November 14, 2023 02:52
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

设计上有几个问题,供讨论:

  1. 选择预置颜色,下方色板不会跟随变化,是否符合预期?
  2. 预置颜色是否应该有选中态?

@jikkai
Copy link
Member Author

jikkai commented Nov 14, 2023

设计上有几个问题,供讨论:

  1. 选择预置颜色,下方色板不会跟随变化,是否符合预期?
  2. 预置颜色是否应该有选中态?

选中态和颜色变化需要产品层面讨论下,改造涉及到 menu 中和 selections 有关的几个接口,不在这个 PR 里扩大修改范围了,我新开个分支处理这个问题吧

@jikkai jikkai merged commit daa57e9 into dev Nov 14, 2023
6 checks passed
@jikkai jikkai deleted the feat/menu-and-colorpicker branch November 14, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants