Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(doc): set bold in selection #346

Merged
merged 13 commits into from
Nov 2, 2023
Merged

feat(doc): set bold in selection #346

merged 13 commits into from
Nov 2, 2023

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Oct 31, 2023 •
edited
Loading

  • Set bold command
  • Undo/Redo set bold
  • Support multiple selections
  • Perceive the style in the selection, cancel it if it's already bold, and bold it if it doesn't

@github-actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

[View Deployment]

@Jocs Jocs force-pushed the feat/set-cell-content-style branch from ff83eab to f4ad03c Compare October 31, 2023 15:18
@Jocs Jocs added the feature request New feature or request label Nov 1, 2023
@Jocs Jocs self-assigned this Nov 1, 2023
@Jocs Jocs marked this pull request as ready for review November 1, 2023 13:15
wzhudev
wzhudev requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following issues need to be addressed before we merge this.

And there is another issue: the toggle bold button in the toolbar should be activated if the selected texts are in bold. @jikkai The sheet demo seems abnormal on this as well. Could you please take a look at it?

packages/base-docs/src/Controller/doc-render.controller.ts Show resolved Hide resolved
packages/base-docs/src/Basics/commonParameter.ts Outdated Show resolved Hide resolved
packages/base-docs/src/Controller/inline-format.controller.ts Show resolved Hide resolved
packages/base-docs/src/commands/mutations/core-editing.mutation.ts Show resolved Hide resolved
packages/core/src/Docs/Domain/DocumentBodyModel.ts Outdated Show resolved Hide resolved
@wzhudev
Copy link
Member

wzhudev commented Nov 1, 2023

The toggling bold shortcut could be implemented in this PR as well?

@Jocs
Copy link
Contributor Author

Jocs commented Nov 1, 2023

The toggling bold shortcut could be implemented in this PR as well?

@wzhudev I tend to put it in a different PR, This PR is mainly to run through the process of inline formats.

@Jocs
Copy link
Contributor Author

Jocs commented Nov 1, 2023 •
edited
Loading

And there is another issue: the toggle bold button in the toolbar should be activated if the selected texts are in bold. @jikkai The sheet demo seems abnormal on this as well. Could you please take a look at it?

@wzhudev This has not been implemented yet, I wrote a method(getFormatValueInSelection) to determine the format in selections, which can be used later.

@wzhudev
Copy link
Member

wzhudev commented Nov 1, 2023

And there is another issue: the toggle bold button in the toolbar should be activated if the selected texts are in bold. @jikkai The sheet demo seems abnormal on this as well. Could you please take a look at it?

@wzhudev This has not been implemented yet, I wrote a method to determine the format in selections, which can be used later.

OK. However, we should fix that for Univer sheet. 💯

@jikkai
Copy link
Member

jikkai commented Nov 1, 2023

The following issues need to be addressed before we merge this.

And there is another issue: the toggle bold button in the toolbar should be activated if the selected texts are in bold. @jikkai The sheet demo seems abnormal on this as well. Could you please take a look at it?

fixed in #364

@Jocs Jocs requested a review from wzhudev November 1, 2023 16:41
@Jocs Jocs merged commit c276ef9 into dev Nov 2, 2023
3 checks passed
@Jocs Jocs deleted the feat/set-cell-content-style branch November 2, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@jikkai jikkai Awaiting requested review from jikkai

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

Assignees

@Jocs Jocs

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jocs @wzhudev @jikkai @DR-Univer