Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): remove unused module #34

Merged
merged 7 commits into from
Jul 19, 2023
Merged

chore(core): remove unused module #34

merged 7 commits into from
Jul 19, 2023

Conversation

Dushusir
Copy link
Member

No description provided.

wzhudev
wzhudev approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dushusir Dushusir requested a review from wzhudev July 18, 2023 06:55
@Dushusir Dushusir marked this pull request as ready for review July 18, 2023 06:55
@Dushusir Dushusir requested review from jerry-TangHao, a user and DR-Univer July 18, 2023 06:56
jerry-TangHao
jerry-TangHao approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@jerry-TangHao jerry-TangHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dushusir Dushusir requested review from a user and removed request for a user July 18, 2023 07:07
@Dushusir Dushusir merged commit cdd7dfc into dev Jul 19, 2023
0 of 2 checks passed
@Dushusir Dushusir deleted the remove-module branch July 19, 2023 03:42
@zhaolixin7 zhaolixin7 mentioned this pull request Apr 30, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerry-TangHao jerry-TangHao jerry-TangHao approved these changes

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dushusir @wzhudev @jerry-TangHao @DR-Univer