Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: permission error should not output to console #3363

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Sep 7, 2024

close #3362

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.19%. Comparing base (15f18c8) to head (e27eefc).
Report is 11 commits behind head on dev.

Files with missing lines Patch % Lines
...on/sheet-permission-interceptor-base.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3363      +/-   ##
==========================================
- Coverage   30.21%   30.19%   -0.03%     
==========================================
  Files        2112     2112              
  Lines      109955   110066     +111     
  Branches    23918    23926       +8     
==========================================
+ Hits        33226    33230       +4     
- Misses      76729    76836     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ybzky ybzky merged commit c795091 into dev Sep 10, 2024
10 checks passed
@ybzky ybzky deleted the chore/change-permission-error-type branch September 10, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants