feat(sheet): editor access to sheet #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzhudev
reviewed
Oct 16, 2023
| // create univer doc editor instance | ||
| univer.createUniverDoc(DOCS_EDITOR_SNAPSHOT); | ||
| // create univer doc normal editor instance | ||
| univer.createUniverDoc({ |
There was a problem hiding this comment.
这个创建的过程应该由 sheet 的 controller 来负责而不是交给用户来做
| } | ||
|
|
||
| export interface ICellEditorManagerService { | ||
| state$: Observable<Nullable<ICellEditorManagerParam>>; |
There was a problem hiding this comment.
建议 ICellEditorManagerParam 接口名称以 state 结尾以和其他 API 保持一致
| } | ||
|
|
||
| private _initialKeyboardListener() { | ||
| this._textSelectionRenderManager.onInput$.subscribe(this._showEditorByKeyboard.bind(this)); |
|
|
||
| // this._textSelectionRenderManager.changeRuntime(docSkeleton, scene); | ||
|
|
||
| this._textSelectionRenderManager.active(-1000, -1000); |
There was a problem hiding this comment.
textSelectionRenderManager 应该暴露一个 deactivate 方法
另外 active 是个形容词, 应该用动词 activate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.