Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): ensure container DOM is removed when destroying Vue 3 components #2892

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Jul 30, 2024

close #2818

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jul 30, 2024
@jikkai jikkai removed the qa:untested This PR is ready to be tested label Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 27.44%. Comparing base (935bdba) to head (6facee5).

Files Patch % Lines
packages/ui/src/common/component-manager.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2892      +/-   ##
==========================================
- Coverage   27.44%   27.44%   -0.01%     
==========================================
  Files        1821     1821              
  Lines       95844    95848       +4     
  Branches    20601    20601              
==========================================
  Hits        26301    26301              
- Misses      69543    69547       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai merged commit 5c38528 into dev Jul 30, 2024
9 checks passed
@jikkai jikkai deleted the fix/vue3 branch July 30, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] When using vue3 components, many empty divs will be repeatedly created
1 participant