Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawing): update #2871

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix(drawing): update #2871

merged 1 commit into from
Jul 29, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Jul 28, 2024

close https://github.com/dream-num/univer-pro/issues/1753

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jul 28, 2024
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.56%. Comparing base (778e371) to head (6f1ca30).

Files Patch % Lines
...ng-ui/src/controllers/drawing-update.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2871      +/-   ##
==========================================
- Coverage   27.56%   27.56%   -0.01%     
==========================================
  Files        1806     1806              
  Lines       95528    95529       +1     
  Branches    20558    20558              
==========================================
  Hits        26335    26335              
- Misses      69193    69194       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 29, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 29, 2024
@DR-Univer DR-Univer merged commit 1880552 into dev Jul 29, 2024
14 checks passed
@DR-Univer DR-Univer deleted the fix-drawing-update branch July 29, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants