Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method to get message portal container #2775

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Jul 15, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@yuhongz yuhongz requested review from jikkai and Jocs as code owners July 15, 2024 13:59
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.30%. Comparing base (26af2cc) to head (e52ec50).
Report is 1 commits behind head on dev.

Files Patch % Lines
...ui/src/services/message/desktop-message.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2775      +/-   ##
==========================================
- Coverage   26.31%   26.30%   -0.01%     
==========================================
  Files        1704     1706       +2     
  Lines       91247    91392     +145     
  Branches    19311    19345      +34     
==========================================
+ Hits        24008    24045      +37     
- Misses      67239    67347     +108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 16, 2024

View Deployment

#9949693515

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@jikkai jikkai merged commit 603d62e into dev Jul 16, 2024
13 checks passed
@jikkai jikkai deleted the yuhongz/feat-add-portal branch July 16, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants