Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): fix the wrong position of validate messages on initialization when the sidebar is open #2676

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Jul 3, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested a review from Jocs as a code owner July 3, 2024 13:37
@jikkai jikkai requested a review from DR-Univer July 3, 2024 13:38
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.04%. Comparing base (0db9c36) to head (92ec409).
Report is 1 commits behind head on dev.

Files Patch % Lines
packages/ui/src/components/editor/TextEditor.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2676      +/-   ##
==========================================
+ Coverage   27.03%   27.04%   +0.01%     
==========================================
  Files        1605     1605              
  Lines       86920    86919       -1     
  Branches    18327    18328       +1     
==========================================
+ Hits        23499    23509      +10     
+ Misses      63421    63410      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant