refactor(doc): refactor doc input #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…um/univer into refactor-base-doc-second
DR-Univer
changed the title
DR-Univer
changed the title
wzhudev
reviewed
Oct 12, 2023
| documentId: string; | ||
| } | ||
|
|
||
| export const SetZoomRatioUndoMutationFactory = ( |
There was a problem hiding this comment.
Zoom 应该是一个 operation 而不是 mutation
| const undoMutationParams = SetZoomRatioUndoMutationFactory(accessor, setZoomRatioMutationParams); | ||
| const result = commandService.executeCommand(SetZoomRatioMutation.id, setZoomRatioMutationParams); | ||
|
|
||
| if (result) { |
There was a problem hiding this comment.
需要支持，excel可以撤销重做的
| @@ -24,21 +23,19 @@ import { | |||
| export const DeleteLeftCommand: ICommand = { | |||
| id: 'doc.command.delete-left', | |||
| type: CommandType.COMMAND, | |||
| handler: async (accessor) => { | |||
There was a problem hiding this comment.
用delete-left.controller拦截实现了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.