Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): ref a1:a gets name error #2666

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Jul 2, 2024

close #2083
close #673
close #689
close #692
close #2144(其他PR修复)

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 26.97%. Comparing base (782fa2b) to head (3fa4e87).
Report is 3 commits behind head on dev.

Files Patch % Lines
...sheets-formula/src/services/description.service.ts 0.00% 3 Missing ⚠️
...gine-formula/src/functions/lookup/vlookup/index.ts 33.33% 2 Missing ⚠️
packages/sheets-formula/src/services/utils.ts 0.00% 1 Missing ⚠️
...-ui/src/views/status-bar/CopyableStatisticItem.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2666      +/-   ##
==========================================
+ Coverage   26.91%   26.97%   +0.05%     
==========================================
  Files        1714     1607     -107     
  Lines       87513    86941     -572     
  Branches    18331    18331              
==========================================
- Hits        23554    23450     -104     
+ Misses      63959    63491     -468     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir marked this pull request as ready for review July 3, 2024 12:03
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jul 3, 2024
@univer-bot
Copy link

univer-bot bot commented Jul 3, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: fix(formula): ref a1:a gets name error

Title: fix(formula): ref a1:a gets name error


close #2083
close #673
close #689
close #692
close #2144(其他PR修复)

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jul 3, 2024
@DR-Univer DR-Univer merged commit 692b30c into dev Jul 4, 2024
9 checks passed
@DR-Univer DR-Univer deleted the dushusir/formula-0703 branch July 4, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
3 participants