Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): dependency error #2650

Merged
merged 3 commits into from
Jul 3, 2024
Merged

fix(sheet): dependency error #2650

merged 3 commits into from
Jul 3, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Jul 1, 2024

close #2030

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@DR-Univer DR-Univer requested a review from Dushusir as a code owner July 1, 2024 14:48
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo
Copy link

oumomomo commented Jul 2, 2024

问题1:
D1引用C1,E1引用D1,修改D1的内容undo后删除C1的内容E1计算结果未更新
2024_7_2 11_34_29 video.webm
2024_7_2 11_35_12 snapshot.json
image

问题2:
C3列输入=sum(A2),A2列输入=sum(A1:C3),C3的计算结果未更新
https://github.com/dream-num/univer/assets/167171356/3fd35caa-0c54-4fb8-975a-6ed7e68172e2
image

@univer-bot
Copy link

univer-bot bot commented Jul 2, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Question 1:
D1 refers to C1, and E1 refers to D1. After modifying the content of D1 undo, the content of C1 is deleted and the calculation result of E1 is not updated.
2024_7_2 11_34_29 video.webm
2024_7_2 11_35_12 snapshot.json
image

Question 2:
Column C3 input =sum(A2), column A2 input =sum(A1:C3), the calculation result of C3 is not updated
https://github.com/dream-num/univer/assets/167171356/3fd35caa-0c54-4fb8-975a-6ed7e68172e2
image

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 2, 2024
@DR-Univer DR-Univer added qa:untested This PR is ready to be tested and removed qa:rejected labels Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.

Project coverage is 27.36%. Comparing base (909f2ee) to head (9c3dd54).
Report is 13 commits behind head on dev.

Files Patch % Lines
...formula/src/services/dependency-manager.service.ts 0.00% 14 Missing ⚠️
...e-formula/src/engine/dependency/dependency-tree.ts 0.00% 6 Missing ⚠️
...-formula/src/services/calculate-formula.service.ts 0.00% 2 Missing ⚠️
...rmula/src/controllers/update-formula.controller.ts 33.33% 2 Missing ⚠️
...ormula/src/engine/dependency/formula-dependency.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2650      +/-   ##
==========================================
- Coverage   27.40%   27.36%   -0.05%     
==========================================
  Files        1707     1709       +2     
  Lines       85677    86081     +404     
  Branches    17906    17990      +84     
==========================================
+ Hits        23481    23552      +71     
- Misses      62196    62529     +333     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo
Copy link

oumomomo commented Jul 2, 2024

问题1删除C1的内容后,D1跟E1单元格0的位置不一样(一左一右)
image

问题2还是可以复现

@univer-bot
Copy link

univer-bot bot commented Jul 2, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Question 1: After deleting the contents of C1, the positions of cell 0 in D1 and E1 are different (one on the left and one on the right)
image

Problem 2 can still be reproduced

@oumomomo oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels Jul 2, 2024
@DR-Univer DR-Univer added qa:untested This PR is ready to be tested and removed qa:rejected labels Jul 2, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 3, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 3, 2024
Copy link
Member

@Dushusir Dushusir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DR-Univer DR-Univer merged commit 4ec356d into dev Jul 3, 2024
9 checks passed
@DR-Univer DR-Univer deleted the fix-dependency-error branch July 3, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Multiple formula results are calculated incorrectly
3 participants