Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drawing issues #2639

Merged
merged 9 commits into from
Jul 2, 2024
Merged

fix: drawing issues #2639

merged 9 commits into from
Jul 2, 2024

Conversation

siam-ese
Copy link
Contributor

@siam-ese siam-ese commented Jun 29, 2024

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 137 lines in your changes missing coverage. Please review.

Project coverage is 26.96%. Comparing base (2f11c2e) to head (e29a4ac).

Current head e29a4ac differs from pull request most recent head 23efc3e

Please upload reports for the commit 23efc3e to get more accurate results.

Files Patch % Lines
...controllers/sheet-drawing-copy-paste.controller.ts 0.00% 77 Missing ⚠️
...ers/sheet-drawing-transform-affected.controller.ts 0.00% 23 Missing ⚠️
...es/drawing-ui/src/views/panel/DrawingTransform.tsx 0.00% 10 Missing ⚠️
...sheets-drawing-ui/src/basics/transform-position.ts 0.00% 8 Missing ⚠️
...ing-ui/src/controllers/image-cropper.controller.ts 0.00% 5 Missing ⚠️
...i/src/controllers/drawing-popup-menu.controller.ts 0.00% 5 Missing ⚠️
...src/controllers/sheet-drawing-update.controller.ts 0.00% 4 Missing ⚠️
packages/sheets-drawing-ui/src/plugin.ts 0.00% 4 Missing ⚠️
packages/engine-render/src/scene.transformer.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2639      +/-   ##
==========================================
- Coverage   27.40%   26.96%   -0.44%     
==========================================
  Files        1708     1695      -13     
  Lines       85906    85323     -583     
  Branches    17949    17786     -163     
==========================================
- Hits        23541    23010     -531     
+ Misses      62365    62313      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 29, 2024

View Deployment

#9761151429

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 29, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 1, 2024
@siam-ese siam-ese added the qa:untested This PR is ready to be tested label Jul 1, 2024
@univer-bot univer-bot bot removed the qa:rejected label Jul 1, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 2, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 2, 2024
@siam-ese siam-ese merged commit 7d35091 into dev Jul 2, 2024
9 checks passed
@siam-ese siam-ese deleted the fix/drawing-issues branch July 2, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants