Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scroll when selection beyond view port #262

Merged
merged 3 commits into from
Oct 11, 2023
Merged

feat: scroll when selection beyond view port #262

merged 3 commits into from
Oct 11, 2023

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Oct 11, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

[View Deployment]

wzhudev
wzhudev requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some problems need to be addressed.

@yuhongz yuhongz merged commit 64ec70b into dev Oct 11, 2023
3 checks passed
@yuhongz yuhongz deleted the yuhongz/feat-scrolling branch October 11, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@jikkai jikkai Awaiting requested review from jikkai

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuhongz @wzhudev