Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(formula): add LEFTB function implementation #2573 #2610

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

feat(formula): add LEFTB function implementation #2573 #2610

wants to merge 3 commits into from

Conversation

sagarwal3005
Copy link

close #2573

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Jun 28, 2024
Dushusir
Dushusir approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@Dushusir Dushusir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oumomomo
Copy link

oumomomo commented Jun 28, 2024 •
edited
Loading

@Dushusir 函数的说明是没有拉语言包嘛
image

@univer-bot
Copy link

univer-bot bot commented Jun 28, 2024 •
edited
Loading

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Dushusir The description of the function does not include a language pack.
image

@oumomomo
Copy link

使用=LEFTB(A2:A3)计算结果有误
image

@oumomomo oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels Jun 29, 2024
@Dushusir
Copy link
Member

Dushusir commented Jul 8, 2024

使用=LEFTB(A2:A3)计算结果有误 image

Move to https://github.com/dream-num/univer-pro/issues/1544 @oumomomo

@univer-bot
Copy link

univer-bot bot commented Jul 8, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

使用=LEFTB(A2:A3)计算结果有误 ![image](https://private-user-images.githubusercontent.com/167171356/344361791-6bd1b82f-46840b-e-e1305. png?jwt= eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsIsIsIsIsImtlCI6MTLECJMJEJ3MJ33LmdpdGh1 ksIm5iZiI6MTcyMDQzMTQwOSwicGF0aCI6Ii8xNjcxNzEzNTYvMzQ0MzYxNzkxLTZiZDFiODJmLTQ5NGItNDY4Zi05ZTBkLTFlM2U2MDFlMzA1YS5wbc1BmXpWbcWbc1BxpJpGbG UzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQS UyRjIwMjQwNzA4JTJGdXMtZWFzdC0xJTJGczMlMkZ3MkZ3MX3ClQCl ZT0yMDI0MDcwOFQwO™2NDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wMmQwNzE0ZTIyyjBlZGYyMTZkZmZiNzUzMjRi5hkGYOTMZOTMZMZMZMZ25x YjMzODJmZTcwMTgxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmt leV9pZD0wJnJlcG9faWQ9MCJ9.Y16YoR5G462v1JVYJVyxxgWkg DY)

Move to https://github.com/dream-num/univer-pro/issues/1544 @oumomomo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dushusir Dushusir Dushusir approved these changes

@DR-Univer DR-Univer Awaiting requested review from DR-Univer DR-Univer is a code owner

Assignees
No one assigned
Labels
qa:rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Text Formula LEFTB
3 participants
@sagarwal3005 @oumomomo @Dushusir