Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): add averagea,concat function #2606

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Jun 24, 2024

  • AVERAGEA
  • CONCAT

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 98.43750% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.15%. Comparing base (2d5de98) to head (1e1922b).
Report is 11 commits behind head on dev.

Files Patch % Lines
...ne-formula/src/functions/text/concatenate/index.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2606      +/-   ##
==========================================
+ Coverage   27.12%   27.15%   +0.02%     
==========================================
  Files        1675     1678       +3     
  Lines       84653    84806     +153     
  Branches    17642    17679      +37     
==========================================
+ Hits        22961    23027      +66     
- Misses      61692    61779      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir changed the title feat(formula): add averagea function feat(formula): add averagea,concat function Jun 24, 2024
@Dushusir Dushusir marked this pull request as ready for review June 24, 2024 13:23
@Dushusir Dushusir requested a review from DR-Univer as a code owner June 24, 2024 13:23
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Jun 24, 2024
@oumomomo
Copy link

oumomomo commented Jun 25, 2024

AVERAGEA函数
1、使用非数字内容,结果为错误码
image
excel/wps:为0
![image](https://github.com/dream-num/univer/assets/167171356/c683afeb-8adc-4dc2-bdab-0f5e9e89b7a7

2、使用数字+非数字,结果为1.5
image
excel、Google:为1
image

@univer-bot
Copy link

univer-bot bot commented Jun 25, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

AVERAGEA function

  1. Use non-numeric content, the result is an error code
    image
    excel/wps: is 0
    ![image](https://github.com/dream-num/univer/assets/167171356/c683afeb-8adc-4dc2-bdab-0f5e9e89b7a7

  2. Use numbers + non-numbers, the result is 1.5
    image
    excel, Google: 1
    image

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 25, 2024
@oumomomo
Copy link

CONCAT函数
1、引用无值的区域报错误码
image
excel:为空
image

@univer-bot
Copy link

univer-bot bot commented Jun 25, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

CONCAT function

  1. An error code is reported when referencing a valueless area.
    image
    excel: empty
    image

@Dushusir
Copy link
Member Author

AVERAGEA 和 CONCAT 已修复

@univer-bot
Copy link

univer-bot bot commented Jun 25, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

AVERAGEA and CONCAT fixed

@Dushusir Dushusir added qa:untested This PR is ready to be tested and removed qa:rejected labels Jun 25, 2024
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge qa:rejected labels Jun 25, 2024
@univer-bot univer-bot bot removed qa:untested This PR is ready to be tested qa:rejected qa:verified This PR has already by verified by a QA and is considered good enough to be merge labels Jun 25, 2024
@Dushusir Dushusir merged commit 346b33a into dev Jun 26, 2024
9 checks passed
@Dushusir Dushusir deleted the dushusir/formula-functions branch June 26, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants