Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add sheet permission facade api #2604

Merged
merged 4 commits into from
Jul 3, 2024
Merged

chore: add sheet permission facade api #2604

merged 4 commits into from
Jul 3, 2024

Conversation

ybzky
Copy link
Contributor

@ybzky ybzky commented Jun 24, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 27.36%. Comparing base (e5020d7) to head (b0f1f32).

Files Patch % Lines
packages/facade/src/apis/sheets/f-workbook.ts 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2604      +/-   ##
==========================================
- Coverage   27.36%   27.36%   -0.01%     
==========================================
  Files        1709     1709              
  Lines       86068    86075       +7     
  Branches    17986    17987       +1     
==========================================
+ Hits        23551    23552       +1     
- Misses      62517    62523       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 24, 2024

View Deployment

#9771140722

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@ybzky ybzky requested a review from wzhudev July 2, 2024 02:47
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 9ca077f into dev Jul 3, 2024
9 checks passed
@wzhudev wzhudev deleted the chore/add-facade-api branch July 3, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants