Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conditional-formatting): add error interceptor #2600

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Jun 24, 2024

close 1133
close 1257
close 735
close 434

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 27.10%. Comparing base (cf60994) to head (b73cef9).
Report is 1 commits behind head on dev.

Files Patch % Lines
...i/src/components/panel/rule-edit/highlightCell.tsx 0.00% 38 Missing ⚠️
...ting-ui/src/components/panel/rule-edit/formula.tsx 0.00% 14 Missing ⚠️
...atting-ui/src/components/panel/rule-edit/index.tsx 0.00% 3 Missing ⚠️
...g-ui/src/components/wrapper-error/WrapperError.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2600      +/-   ##
==========================================
- Coverage   27.11%   27.10%   -0.02%     
==========================================
  Files        1675     1676       +1     
  Lines       84710    84746      +36     
  Branches    17656    17660       +4     
==========================================
  Hits        22968    22968              
- Misses      61742    61778      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 24, 2024

View Deployment

#9657960899

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@zhaolixin7 zhaolixin7 added the qa:untested This PR is ready to be tested label Jun 25, 2024
@Gggpound Gggpound force-pushed the feat-cf-add-error-interceptor-0624 branch from 234055e to fbddda9 Compare June 25, 2024 06:47
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 25, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 25, 2024
@Gggpound Gggpound force-pushed the feat-cf-add-error-interceptor-0624 branch from fbddda9 to b73cef9 Compare June 25, 2024 06:55
@Gggpound Gggpound merged commit b523f62 into dev Jun 25, 2024
9 checks passed
@Gggpound Gggpound deleted the feat-cf-add-error-interceptor-0624 branch June 25, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants