Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: numfmt i18n #2595

Merged
merged 3 commits into from
Jun 26, 2024
Merged

chore: numfmt i18n #2595

merged 3 commits into from
Jun 26, 2024

Conversation

siam-ese
Copy link
Contributor

close https://github.com/dream-num/univer-workspace/issues/260

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@siam-ese siam-ese requested a review from Gggpound as a code owner June 24, 2024 03:12
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.11%. Comparing base (be947bd) to head (5acb14f).
Report is 45 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2595      +/-   ##
==========================================
- Coverage   27.16%   27.11%   -0.06%     
==========================================
  Files        1653     1675      +22     
  Lines       83508    84653    +1145     
  Branches    17368    17642     +274     
==========================================
+ Hits        22685    22951     +266     
- Misses      60823    61702     +879     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai
Copy link
Member

jikkai commented Jun 24, 2024

Russian?

Copy link

View Deployment

#9639041650

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@siam-ese siam-ese merged commit 75dde65 into dev Jun 26, 2024
9 checks passed
@siam-ese siam-ese deleted the chore/numfmt-i18n branch June 26, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants