Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export drawing type #2591

Merged
merged 1 commit into from
Jun 22, 2024
Merged

chore: export drawing type #2591

merged 1 commit into from
Jun 22, 2024

Conversation

siam-ese
Copy link
Contributor

For issue https://github.com/dream-num/univer-pro/pull/1280

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.08%. Comparing base (b1dc036) to head (da0e0df).
Report is 29 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2591      +/-   ##
==========================================
- Coverage   27.19%   27.08%   -0.11%     
==========================================
  Files        1653     1677      +24     
  Lines       83583    84851    +1268     
  Branches    17391    17662     +271     
==========================================
+ Hits        22729    22986     +257     
- Misses      60854    61865    +1011     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@siam-ese siam-ese requested a review from wzhudev June 22, 2024 03:57
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 43852b9 into dev Jun 22, 2024
9 checks passed
@wzhudev wzhudev deleted the chore/export-type-from-drawing branch June 22, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants