-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): introduce eventsubject to replace internal observable #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzhudev
changed the title
refactor(core): remove observer redundant code
refactor(core): remove legacy observer and use rxjs instead
Jun 22, 2024
wzhudev
force-pushed
the
refactor/event-observer
branch
from
June 22, 2024 04:04
d475993
to
aa8e989
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2590 +/- ##
==========================================
+ Coverage 26.93% 26.95% +0.01%
==========================================
Files 1690 1692 +2
Lines 85230 85155 -75
Branches 17727 17736 +9
==========================================
- Hits 22955 22951 -4
+ Misses 62275 62204 -71 ☔ View full report in Codecov by Sentry. |
View Deployment
|
wzhudev
requested review from
ybzky,
yuhongz,
DR-Univer,
Dushusir,
Jocs,
jikkai and
lumixraku
as code owners
June 22, 2024 05:48
wzhudev
changed the title
refactor(core): remove legacy observer and use rxjs instead
refactor(core): introduce eventsubject to replace internal observable
Jun 22, 2024
lumixraku
force-pushed
the
refactor/event-observer
branch
from
June 22, 2024 09:55
1fd2aa4
to
f22e8dc
Compare
Jocs
approved these changes
Jun 22, 2024
lumixraku
force-pushed
the
refactor/event-observer
branch
8 times, most recently
from
June 25, 2024 04:10
899fb27
to
22c2106
Compare
lumixraku
force-pushed
the
refactor/event-observer
branch
from
June 25, 2024 13:12
22c2106
to
856ecb9
Compare
and prepare to migrate to rxjs
feat: pointermove to rxjs
feat: pointerup to rxjs chore: pointerUp remove
lumixraku
force-pushed
the
refactor/event-observer
branch
from
June 26, 2024 04:41
856ecb9
to
2ac2523
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we (@lumixraku & me) removed the legacy reactive programming pattern
Observable
andObserver
from thecore
package to use customEventSubject
instead. Not only it keeps the stop propagation functionality the oldObservable
provided, but also leverages RxJS.Pull Request Checklist