Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): export vars for sort plugin #2587

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Jun 21, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.92%. Comparing base (e5020d7) to head (3d03722).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2587      +/-   ##
==========================================
- Coverage   27.36%   26.92%   -0.44%     
==========================================
  Files        1709     1714       +5     
  Lines       86068    87513    +1445     
  Branches    17986    18331     +345     
==========================================
+ Hits        23551    23564      +13     
- Misses      62517    63949    +1432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We are good to go once the CI problem is fixed.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We are good to go once the CI problem is fixed.

@yuhongz yuhongz merged commit 4c1c3de into dev Jul 3, 2024
9 checks passed
@yuhongz yuhongz deleted the yuhongz/add-exports-2 branch July 3, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants