Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-data-validation): bugfix for data-validation #2562

Merged
merged 11 commits into from
Jun 20, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jun 19, 2024

close
https://github.com/dream-num/univer-pro/issues/1244
https://github.com/dream-num/univer-pro/issues/1254
https://github.com/dream-num/univer-pro/issues/1153
#1949

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 13.04348% with 20 lines in your changes missing coverage. Please review.

Project coverage is 27.06%. Comparing base (9c4ea35) to head (b9fa4fa).

Current head b9fa4fa differs from pull request most recent head 133ba9d

Please upload reports for the commit 133ba9d to get more accurate results.

Files Patch % Lines
...idation/src/controllers/dv-auto-fill.controller.ts 0.00% 12 Missing ⚠️
...ets-data-validation/src/widgets/dropdown-widget.ts 0.00% 3 Missing ⚠️
packages/sheets/src/services/ref-range/util.ts 50.00% 3 Missing ⚠️
...sheets-hyper-link-ui/src/services/popup.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2562      +/-   ##
==========================================
- Coverage   27.06%   27.06%   -0.01%     
==========================================
  Files        1677     1677              
  Lines       84749    84763      +14     
  Branches    17624    17625       +1     
==========================================
  Hits        22938    22938              
- Misses      61811    61825      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 19, 2024

View Deployment

#9598134081

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@weird94 weird94 requested a review from jikkai as a code owner June 19, 2024 16:13
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 20, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 20, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weird94 weird94 merged commit d1e38dd into dev Jun 20, 2024
9 checks passed
@weird94 weird94 deleted the fix/daily-zw-0619 branch June 20, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants