Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): add minifs function #2561

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Jun 19, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir marked this pull request as ready for review June 19, 2024 12:59
@Dushusir Dushusir requested a review from DR-Univer as a code owner June 19, 2024 12:59
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 86.87500% with 21 lines in your changes missing coverage. Please review.

Project coverage is 27.11%. Comparing base (107fbf2) to head (fe2a0c9).
Report is 5 commits behind head on dev.

Current head fe2a0c9 differs from pull request most recent head 2f4b944

Please upload reports for the commit 2f4b944 to get more accurate results.

Files Patch % Lines
...mula/src/functions/statistical/averageifs/index.ts 82.14% 5 Missing ⚠️
...-formula/src/functions/statistical/minifs/index.ts 82.14% 5 Missing ⚠️
...formula/src/functions/statistical/countif/index.ts 80.00% 4 Missing ⚠️
...rmula/src/functions/statistical/averageif/index.ts 85.71% 3 Missing ⚠️
...es/engine-formula/src/engine/utils/value-object.ts 95.23% 2 Missing ⚠️
.../engine-formula/src/functions/math/sumifs/index.ts 85.71% 1 Missing ⚠️
...-formula/src/functions/statistical/maxifs/index.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2561      +/-   ##
==========================================
+ Coverage   27.01%   27.11%   +0.09%     
==========================================
  Files        1675     1681       +6     
  Lines       84721    84844     +123     
  Branches    17613    17649      +36     
==========================================
+ Hits        22888    23004     +116     
- Misses      61833    61840       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant