Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): adjust tooltip arrow width to 4px #2556

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Jun 19, 2024

close https://github.com/dream-num/univer-pro/issues/1137

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.10%. Comparing base (bc108e5) to head (c924f93).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2556   +/-   ##
=======================================
  Coverage   27.10%   27.10%           
=======================================
  Files        1654     1654           
  Lines       83894    83894           
  Branches    17459    17459           
=======================================
  Hits        22741    22741           
  Misses      61153    61153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 9992773 into dev Jun 19, 2024
8 of 9 checks passed
@wzhudev wzhudev deleted the fix/tooltip-arrow branch June 19, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants