feat(formula): add FINDB function implementation #2538 #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 13, 2024 14:23
View Deployment
🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪 |
Dushusir
reviewed
Jun 18, 2024
| describe('Find', () => { | ||
| it('Find text in single cell', () => { | ||
| const findText = StringValueObject.create('Univer'); | ||
| const withinText = StringValueObject.create('Hello Univer'); |
There was a problem hiding this comment.
If withinText is "你好 Univer", the result will be 6
You can refer to the calculation of byte length in the LENB function, especially for characters in special languages. We have a public method for reference charLenByte, refer to
Additional note:
The purpose of making a public tool method charLenByte is to make modification and maintenance easier. This method is not necessarily perfect. If you can find a better solution, please contribute to us.
|
Pay attention to the format of the PR title. Use |
sagarwal3005
changed the title
|
Please check all test cases passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2538