Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sheet drawing permission #2546

Merged
merged 15 commits into from
Jun 19, 2024
Merged

feat: add sheet drawing permission #2546

merged 15 commits into from
Jun 19, 2024

Conversation

ybzky
Copy link
Contributor

@ybzky ybzky commented Jun 18, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 233 lines in your changes missing coverage. Please review.

Project coverage is 27.10%. Comparing base (be947bd) to head (963a29b).
Report is 17 commits behind head on dev.

Files Patch % Lines
...controllers/sheet-drawing-permission.controller.ts 0.00% 166 Missing ⚠️
...ts-hyper-link-ui/src/views/CellLinkPopup/index.tsx 0.00% 18 Missing ⚠️
...-hyper-link-ui/src/controllers/popup.controller.ts 0.00% 11 Missing ⚠️
...awing/src/services/drawing-manager-impl.service.ts 0.00% 10 Missing ⚠️
.../drawing-ui/src/services/drawing-render.service.ts 0.00% 7 Missing ⚠️
...rc/controllers/sheets-thread-comment.controller.ts 0.00% 6 Missing ⚠️
...ts-ui/src/controllers/menu/permission-menu-util.ts 0.00% 6 Missing ⚠️
...trollers/sheets-thread-comment-hover.controller.ts 0.00% 5 Missing ⚠️
...sheets-hyper-link-ui/src/services/popup.service.ts 0.00% 1 Missing ⚠️
.../commands/commands/worksheet-protection.command.ts 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2546      +/-   ##
==========================================
- Coverage   27.16%   27.10%   -0.06%     
==========================================
  Files        1653     1654       +1     
  Lines       83508    83894     +386     
  Branches    17368    17459      +91     
==========================================
+ Hits        22685    22741      +56     
- Misses      60823    61153     +330     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@ybzky ybzky merged commit bc108e5 into dev Jun 19, 2024
9 checks passed
@ybzky ybzky deleted the feat-sheet-drawing-permission branch June 19, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants