Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: button style #2541

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fix: button style #2541

merged 2 commits into from
Jun 18, 2024

Conversation

siam-ese
Copy link
Contributor

@siam-ese siam-ese commented Jun 17, 2024

close #242

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.16%. Comparing base (be947bd) to head (33e03ff).
Report is 4 commits behind head on dev.

Files Patch % Lines
...ui/src/components/range-selector/RangeSelector.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2541   +/-   ##
=======================================
  Coverage   27.16%   27.16%           
=======================================
  Files        1653     1653           
  Lines       83508    83562   +54     
  Branches    17368    17384   +16     
=======================================
+ Hits        22685    22701   +16     
- Misses      60823    60861   +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 17, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 18, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 18, 2024
@siam-ese siam-ese merged commit b753dba into dev Jun 18, 2024
10 checks passed
@siam-ese siam-ese deleted the fix/button-style branch June 18, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants