Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets): fix some bugs #2536

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix(sheets): fix some bugs #2536

merged 1 commit into from
Jun 17, 2024

Conversation

ybzky
Copy link
Contributor

@ybzky ybzky commented Jun 17, 2024

close #2150 #2001 #1131 #905

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 16.27907% with 36 lines in your changes missing coverage. Please review.

Project coverage is 27.17%. Comparing base (be947bd) to head (5e3140e).

Files Patch % Lines
...ommands/commands/remove-worksheet-merge.command.ts 0.00% 22 Missing ⚠️
packages/ui/src/utils/cell.ts 0.00% 7 Missing ⚠️
...rc/commands/mutations/set-range-values.mutation.ts 20.00% 4 Missing ⚠️
...la/src/controllers/formula-clipboard.controller.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2536   +/-   ##
=======================================
  Coverage   27.16%   27.17%           
=======================================
  Files        1653     1653           
  Lines       83508    83539   +31     
  Branches    17368    17374    +6     
=======================================
+ Hits        22685    22699   +14     
- Misses      60823    60840   +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 17, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 17, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 17, 2024
@ybzky ybzky merged commit 250763e into dev Jun 17, 2024
10 checks passed
@ybzky ybzky deleted the fix/bugs-yb-0617 branch June 17, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] After pasting content into the table, the content in the original area is not overwritten.
3 participants