Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(conditional-formatting): separate the initialization logic for U… #2530

Merged
merged 1 commit into from
Jun 15, 2024
Merged

feat(conditional-formatting): separate the initialization logic for U… #2530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/sheets-conditional-formatting-ui/src/controllers/cf.menu.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import { ConditionFormattingPanel } from '../components/panel';

export interface IUniverSheetsConditionalFormattingUIConfig {
menu: MenuConfig;
skipConditionalFormattingCore?: boolean;
}

export const DefaultSheetConditionalFormattingUiConfig = {};
Expand Down
24 changes: 17 additions & 7 deletions packages/sheets-conditional-formatting-ui/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import { ConditionalFormattingClearController } from './controllers/cf.clear.con
import { ConditionalFormattingPermissionController } from './controllers/cf.permission.controller';

export class UniverSheetsConditionalFormattingUIPlugin extends Plugin {
static override pluginName = SHEET_CONDITIONAL_FORMATTING_PLUGIN;
static override pluginName = `${SHEET_CONDITIONAL_FORMATTING_PLUGIN}_UI`;
static override type = UniverInstanceType.UNIVER_SHEET;

static commandList = [
Expand All @@ -69,17 +69,21 @@ export class UniverSheetsConditionalFormattingUIPlugin extends Plugin {
];

constructor(
private readonly _config: Partial<IUniverSheetsConditionalFormattingUIConfig> = {},
private readonly _config: Partial<IUniverSheetsConditionalFormattingUIConfig> = {
},
@Inject(Injector) override readonly _injector: Injector,
@Inject(ICommandService) private _commandService: ICommandService
) {
super();
this._config = Tools.deepMerge({}, DefaultSheetConditionalFormattingUiConfig, this._config);

const skipConditionalFormattingCore = this._config.skipConditionalFormattingCore ?? false;
this._initCommand();
SheetsConditionalFormattingPlugin.dependencyList.forEach((dependency) => {
this._injector.add(dependency);
});
if (!skipConditionalFormattingCore) {
SheetsConditionalFormattingPlugin.dependencyList.forEach((dependency) => {
this._injector.add(dependency);
});
}

this._injector.add([SheetsCfRenderController]);
this._injector.add([SheetsCfRefRangeController]);
this._injector.add([ConditionalFormattingCopyPasteController]);
Expand All @@ -97,7 +101,13 @@ export class UniverSheetsConditionalFormattingUIPlugin extends Plugin {
}

_initCommand() {
[...SheetsConditionalFormattingPlugin.mutationList, ...UniverSheetsConditionalFormattingUIPlugin.commandList].forEach((m) => {
const skipConditionalFormattingCore = this._config.skipConditionalFormattingCore ?? false;
if (!skipConditionalFormattingCore) {
SheetsConditionalFormattingPlugin.mutationList.forEach((m) => {
this._commandService.registerCommand(m);
});
}
[...UniverSheetsConditionalFormattingUIPlugin.commandList].forEach((m) => {
this._commandService.registerCommand(m);
});
}
Expand Down
Loading