Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change permission collaborator #2528

Merged
merged 4 commits into from
Jun 15, 2024
Merged

fix: change permission collaborator #2528

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de1c16e
fix: change permission collaborator
ybzky Jun 15, 2024
47e83d9
fix: fix test
ybzky Jun 15, 2024
6e922fa
chore: reset menu
ybzky Jun 15, 2024
632039a
chore: reset menu
ybzky Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: reset menu
  • Loading branch information
@ybzky
ybzky committed Jun 15, 2024
commit 6e922fa7b8c9751c6106e494eb5545c5525dcd17
2 changes: 1 addition & 1 deletion packages/sheets-ui/src/controllers/menu/__tests__/menu.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,10 @@ describe('test menu items', () => {
disposableCollection.add(menuItem.activated$!.subscribe((v: boolean) => (activated = v)));
disposableCollection.add(menuItem.disabled$!.subscribe((v: boolean) => (disabled = v)));
expect(activated).toBeFalsy();
expect(disabled).toBeFalsy();

select({ startRow: 0, startColumn: 0, endRow: 0, endColumn: 0 });
expect(await commandService.executeCommand(SetBoldCommand.id)).toBeTruthy();
expect(activated).toBe(true);
expect(disabled).toBeFalsy();
});
});
Loading