Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets): bugfix for data-validation and hyper-link #2527

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jun 14, 2024

close
https://github.com/dream-num/univer-pro/issues/1186
https://github.com/dream-num/univer-pro/issues/1205
https://github.com/dream-num/univer-pro/issues/1179

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 27.15%. Comparing base (8a1bf8d) to head (66e3515).
Report is 7 commits behind head on dev.

Current head 66e3515 differs from pull request most recent head 2612d41

Please upload reports for the commit 2612d41 to get more accurate results.

Files Patch % Lines
...er-link-ui/src/controllers/set-range.controller.ts 0.00% 4 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 2 Missing ⚠️
...validation/src/controllers/dv-render.controller.ts 0.00% 1 Missing ⚠️
packages/sheets-hyper-link-ui/src/common/util.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2527      +/-   ##
==========================================
- Coverage   27.15%   27.15%   -0.01%     
==========================================
  Files        1654     1654              
  Lines       83330    83335       +5     
  Branches    17258    17262       +4     
==========================================
+ Hits        22626    22627       +1     
- Misses      60704    60708       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 14, 2024

View Deployment

#9543916015

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jun 15, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some improvements would be better.

@weird94 weird94 merged commit 389e65b into dev Jun 17, 2024
9 checks passed
@weird94 weird94 deleted the fix/daily-zw-0514 branch June 17, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants