Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some permission bugs #2522

Merged
merged 3 commits into from
Jun 14, 2024
Merged

fix: fix some permission bugs #2522

merged 3 commits into from
Jun 14, 2024

Conversation

ybzky
Copy link
Contributor

@ybzky ybzky commented Jun 14, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 27.16%. Comparing base (ca76011) to head (6f766a1).
Report is 6 commits behind head on dev.

Files Patch % Lines
...permission-interceptor-canvas-render.controller.ts 0.00% 12 Missing ⚠️
...heets-ui/src/views/permission/panel-list/index.tsx 0.00% 4 Missing ⚠️
...on/sheet-permission-interceptor-base.controller.ts 0.00% 2 Missing ⚠️
...rc/services/selection/selection-shape-extension.ts 0.00% 2 Missing ⚠️
...ges/sheets-ui/src/views/formula-bar/FormulaBar.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2522   +/-   ##
=======================================
  Coverage   27.16%   27.16%           
=======================================
  Files        1653     1654    +1     
  Lines       83357    83354    -3     
  Branches    17263    17258    -5     
=======================================
  Hits        22642    22642           
+ Misses      60715    60712    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@ybzky ybzky merged commit ac0644b into dev Jun 14, 2024
9 checks passed
@ybzky ybzky deleted the fix-permission-bugs branch June 14, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants