Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support props on float dom component #2518

Merged
merged 3 commits into from
Jun 14, 2024
Merged

feat: support props on float dom component #2518

merged 3 commits into from
Jun 14, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jun 14, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested review from jikkai and Jocs as code owners June 14, 2024 03:00
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types could be optimized.

packages/ui/src/services/dom/canvas-dom-layer.service.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 27.15%. Comparing base (ca76011) to head (214b8d7).

Current head 214b8d7 differs from pull request most recent head a5fefeb

Please upload reports for the commit a5fefeb to get more accurate results.

Files Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 3 Missing ⚠️
packages/ui/src/views/components/dom/FloatDom.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2518      +/-   ##
==========================================
- Coverage   27.16%   27.15%   -0.02%     
==========================================
  Files        1653     1653              
  Lines       83357    83358       +1     
  Branches    17263    17263              
==========================================
- Hits        22642    22633       -9     
- Misses      60715    60725      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 14, 2024

View Deployment

#9510133989

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@weird94 weird94 merged commit 0a52859 into dev Jun 14, 2024
8 of 9 checks passed
@weird94 weird94 deleted the fix/float-dom branch June 14, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants